On Tue, Jun 24, 2008 at 11:20:34PM -0700, Bernard Li wrote: > The code Jesse checked into trunk has introduced some formatting > changes to graph titles that are still being sorted out.
is there any other ganglia developer list I should be aware of? do you care to provide some specifics? > Also, IMHO the hostname conversion shouldn't be done in each graph.d/ > .php file, but instead done in ganglia.php. obviously you didn't read my email below. there is nothing wrong with doing it on each of the graph.d specific files because this is not a "hostname conversion", but just a simple style transformation, like deciding which title to use. > Jesse mentioned that > there are issue right now with $hostname being used as the file name > for the .rrd file. We should instead take this opportunity to > implement a function to determine a UUID for the rrd filename (right > now it will be $hosname). This way we can kill two birds with one > stone. this is just feature creep and unrelated to this issue. it is also a very bad design decision to generate an UUID when you have one already (the FQDN) Carlo PS. original mail, relevant to this original topic follows ----------------- REAL THREAD STARTS HERE -------------------- > On Tue, Jun 24, 2008 at 11:31 PM, Carlo Marcelo Arenas Belon > <[EMAIL PROTECTED]> wrote: > > On Tue, Jun 24, 2008 at 02:44:01PM -0400, Jesse Becker wrote: > >> I just committed r1460 to trunk. This adds the $use_fqdn_hostname > >> setting to conf.php. The default behavior is to *not* show the FQDN. > > > > for backward compatibility reasons we should keep the default as it was > > before > > (which is to show the FQDN) or more specifically to use the exact hostname > > that was being reported by gmetad without any post processing or formatting. > > > >> The patch adds a small utility function to remove everything after the > >> first "." character in a hostname, and then adds checks for > >> $use_fqdn_hostname in the various graphing functions. > > > > a better name might be $strip_domainname as it will reflect better what > > it is doing. > > > >> It is possible to turn this option on, so that the FQDN is shown, but > >> hosts that report themselves using only a short hostname will still be > >> displayed as such, since we can't magically conjure an arbitrary > >> domain for hosts that lack them. > > > > making up a domain name isn't needed or desirable, but as I explained before > > this functionality should be instead seen as some means to reformat the name > > of the nodes so that they can be better represented in the graphs/reports. > > > > attached backported version of your patch to 3.1 that includes the changes > > explained above and some small formatting fixes. > > > > Carlo ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
