Yes, I agree. Ian
On Thu, 21 Feb 2019 at 06:13, Andrea Aime <andrea.a...@geo-solutions.it> wrote: > That sounds good to me... We can have it sit on master for some time and > then backport if there are no issues? > > Cheers > Andrea > > Il mer 20 feb 2019, 23:19 Jody Garnett <jody.garn...@gmail.com> ha > scritto: > >> Reviewing release notes: >> https://github.com/locationtech/jts/releases/tag/jts-1.16.1 show >> HilbertCode and MortonCode (new functionality), improved InteriorPointArea >> performance/robustness and some bug fixes. >> >> While we took on this upgrade to solve a bug reported during our RC >> testing I I am not interested in delaying this release if folks are >> uncomfortable. We can back out this upgrade and apply it after the release. >> >> >> >> On Wed, Feb 20, 2019 at 12:35 AM Ian Turton <ijtur...@gmail.com> wrote: >> >>> This does look like a big change at the last minute. However on a quick >>> review it does look like most of the changes are to tests or are >>> documentation changes. But there are some actual code changes too, so >>> without a longer review I would be against this change just before the >>> release. >>> >>> Ian >>> >>> On Wed, 20 Feb 2019 at 07:13, Andrea Aime <andrea.a...@geo-solutions.it> >>> wrote: >>> >>>> Hi, >>>> so Jody is releasing GeoTools 21.0 after upgrading from JTS 1.16.0 to >>>> 1.16.1, last minute, >>>> without having the changes around for any useful amount of time: >>>> >>>> https://github.com/geotools/geotools/commit/7e0fa08aa877616662eba8baec30f0a1776f9434 >>>> >>>> I was against it, but Jody claims it's only a bug fix, from his last >>>> mail: >>>> "I can do it, trying to wrestle with recompiling all the things (due to >>>> this API change) or back porting just the bug fix reported by Hughe." >>>> >>>> This is the diff between the JTS 1.16.0 and 1.16.1: >>>> https://github.com/locationtech/jts/compare/jts-1.16.0...jts-1.16.1 >>>> >>>> Please double check that I got it right, because it says that there are >>>> 198 files changed and tens of commits. >>>> Is this the supposed "back porting just the bug fix reported by Hughe"? >>>> >>>> Cheers >>>> Andrea >>>> >>>> == GeoServer Professional Services from the experts! Visit >>>> http://goo.gl/it488V for more information. == Ing. Andrea Aime >>>> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 >>>> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 >>>> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it >>>> ------------------------------------------------------- *Con >>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>>> precisa che ogni circostanza inerente alla presente email (il suo >>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>>> This email is intended only for the person or entity to which it is >>>> addressed and may contain information that is privileged, confidential or >>>> otherwise protected from disclosure. We remind that - as provided by >>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>>> e-mail or the information herein by anyone other than the intended >>>> recipient is prohibited. If you have received this email by mistake, please >>>> notify us immediately by telephone or e-mail.* >>>> _______________________________________________ >>>> GeoTools-Devel mailing list >>>> GeoTools-Devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>> >>> >>> >>> -- >>> Ian Turton >>> _______________________________________________ >>> GeoTools-Devel mailing list >>> GeoTools-Devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> -- Ian Turton
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
