On Mon Oct 8 00:18:40 BST 2018, Peter S Kirk wrote:
Until recently, subtitles were downloaded first
thus get_i pvr could be stopped once done.
Now they are downloaded after video. Why?
... Because the powers that be (i.e. the one and only
person still maintaining the code of GiP) decreed so:
https://github.com/get-iplayer/get_iplayer/commit/35d8e7b4d23815b85937727868bd9364ae829f0a
The logic behind that change appears to be
# Get subtitles if they exist and are required and media download
succeeded
i.e. the author ASSUMES you wouldn't want the subs
(only) if the actual media download failed...
The status quo ante was:
# Get subtitles if they exist and are required
# best to do this before streaming file so that the subtitles can be
enjoyed while recording progresses
In any case, even back when the subs were fetched
before media download completion, they still had
the ".partial.srt" suffix and that was only removed
when the video itself was fully dumped to file...
And it wasn't a "recent"change, 't was more than a year ago...
(... I couldn't help noticing the comment
to the aforelinked commit:
https://github.com/get-iplayer/get_iplayer/commit/35d8e7b4d23815b85937727868bd9364ae829f0a#commitcomment-25039704
which, of course, remains unanswered to this day...)
Best regards,
Vangelis.
_______________________________________________
get_iplayer mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/get_iplayer
