On 08/10/18 03:02, Vangelis forthnet wrote:
On Mon Oct 8 00:18:40 BST 2018, Peter S Kirk wrote:
Until recently, subtitles were downloaded first
thus get_i pvr could be stopped once done.
Now they are downloaded after video. Why?
... Because the powers that be (i.e. the one and only
person still maintaining the code of GiP) decreed so:
https://github.com/get-iplayer/get_iplayer/commit/35d8e7b4d23815b85937727868bd9364ae829f0a
The logic behind that change appears to be
# Get subtitles if they exist and are required and media download
succeeded
i.e. the author ASSUMES you wouldn't want the subs
(only) if the actual media download failed...
The status quo ante was:
# Get subtitles if they exist and are required
# best to do this before streaming file so that the subtitles can be
enjoyed while recording progresses
Hi Vangelis
That is not quite the whole story. There were a few programmes whose
subtitle XML files (TTML?) were corrupt. They included some NUL
characters and, I am told, NUL is not a valid character in XML.
The code was changed to ignore NUL characters. As an additional measure
downloading of subtitles was delayed until the end to reduce the risk
that errors in subtitles could cause the whole download to fail.
Best wishes
Richard
_______________________________________________
get_iplayer mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/get_iplayer
