Abacn commented on code in PR #38357:
URL: https://github.com/apache/beam/pull/38357#discussion_r3182057298
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -185,6 +185,12 @@ public interface DataflowPipelineOptions
void setPipelineUrl(String urlString);
+ /** The hex-encoded SHA256 hash of the staged portable pipeline proto. */
+ @Description("The hex-encoded SHA256 hash of the staged portable pipeline
proto")
Review Comment:
Does this refer to a Beam model pipeline proto or (already translated)
dataflow v1beta3 pipeline proto?
(a glace at the code change it appears to be the former case)
https://github.com/tarun-google/beam/blob/70464a92db1a01b24210ce8c1abc4faad86e6987/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L1365
but the sdk side change are all dataflow specific
If it's a Beam proto it's generic therefore consider put it to
SDKHarnessOptions (in Java core). If it's a v1beta3 proto it's indeed Dataflow
specific, consider a more specific pipeline option naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
