tarun-google commented on code in PR #38357:
URL: https://github.com/apache/beam/pull/38357#discussion_r3183154587
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -185,6 +185,12 @@ public interface DataflowPipelineOptions
void setPipelineUrl(String urlString);
+ /** The hex-encoded SHA256 hash of the staged portable pipeline proto. */
+ @Description("The hex-encoded SHA256 hash of the staged portable pipeline
proto")
Review Comment:
Agreed this is generic proto and not specific to beam. But it feels better
to keep both the PipelineURL and pipelineProtoHash together. Can i move both of
them? This should not break Runner Harness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
