Revision: 2217
          http://gtkpod.svn.sourceforge.net/gtkpod/?rev=2217&view=rev
Author:   jcsjcs
Date:     2009-01-17 06:14:37 +0000 (Sat, 17 Jan 2009)

Log Message:
-----------
        * src/rb_rating_helper.c: display a warning if one of the star
          icons cannot be loaded.

Modified Paths:
--------------
    gtkpod/trunk/ChangeLog
    gtkpod/trunk/src/rb_rating_helper.c

Modified: gtkpod/trunk/ChangeLog
===================================================================
--- gtkpod/trunk/ChangeLog      2009-01-17 05:47:46 UTC (rev 2216)
+++ gtkpod/trunk/ChangeLog      2009-01-17 06:14:37 UTC (rev 2217)
@@ -1,5 +1,10 @@
 2008-01-17 Jorg Schuler <jcsjcs at users.sourceforge.net>
 
+       * src/rb_rating_helper.c: display a warning if one of the star
+         icons cannot be loaded.
+
+2008-01-17 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
        * src/display_tracks.c: let gtkpod remember column sizes again.
 
        * src/prefs.c: enable horizontal scrollbar in the track view by

Modified: gtkpod/trunk/src/rb_rating_helper.c
===================================================================
--- gtkpod/trunk/src/rb_rating_helper.c 2009-01-17 05:47:46 UTC (rev 2216)
+++ gtkpod/trunk/src/rb_rating_helper.c 2009-01-17 06:14:37 UTC (rev 2217)
@@ -68,9 +68,6 @@
        gint width;
 
        pixbufs = g_new0 (RBRatingPixbufs, 1);
-       if (pixbufs == NULL) {
-               return NULL;
-       }
 
        theme = gtk_icon_theme_get_default ();
        gtk_icon_size_lookup (GTK_ICON_SIZE_MENU, NULL, &width);
@@ -95,10 +92,13 @@
            pixbufs->pix_blank != NULL) {
                return pixbufs;
        }
-
-       rb_rating_pixbufs_free (pixbufs);
-       g_free (pixbufs);
-       return NULL;
+       else
+       {
+           rb_rating_pixbufs_free (pixbufs);
+           g_free (pixbufs);
+           g_warning ("Unable to load at least one of the following icons: " 
RB_STOCK_SET_STAR ", " RB_STOCK_UNSET_STAR " and " RB_STOCK_NO_STAR ". 
Displaying of the star rating will not work.\n");
+           return NULL;
+       }
 }
 
 gboolean


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2

Reply via email to