Revision: 2218
          http://gtkpod.svn.sourceforge.net/gtkpod/?rev=2218&view=rev
Author:   jcsjcs
Date:     2009-01-17 10:54:46 +0000 (Sat, 17 Jan 2009)

Log Message:
-----------
        * src/file_convert.c (conversion_log_set_status): don't change tab
          label text in conversion log window unless actually
          necessary. Fixes the "disappearing tooltips" problem (tracker
          #1906016).

Modified Paths:
--------------
    gtkpod/trunk/ChangeLog
    gtkpod/trunk/src/file_convert.c

Modified: gtkpod/trunk/ChangeLog
===================================================================
--- gtkpod/trunk/ChangeLog      2009-01-17 06:14:37 UTC (rev 2217)
+++ gtkpod/trunk/ChangeLog      2009-01-17 10:54:46 UTC (rev 2218)
@@ -1,5 +1,12 @@
 2008-01-17 Jorg Schuler <jcsjcs at users.sourceforge.net>
 
+       * src/file_convert.c (conversion_log_set_status): don't change tab
+         label text in conversion log window unless actually
+         necessary. Fixes the "disappearing tooltips" problem (tracker
+         #1906016).
+
+2008-01-17 Jorg Schuler <jcsjcs at users.sourceforge.net>
+
        * src/rb_rating_helper.c: display a warning if one of the star
          icons cannot be loaded.
 

Modified: gtkpod/trunk/src/file_convert.c
===================================================================
--- gtkpod/trunk/src/file_convert.c     2009-01-17 06:14:37 UTC (rev 2217)
+++ gtkpod/trunk/src/file_convert.c     2009-01-17 10:54:46 UTC (rev 2218)
@@ -566,19 +566,28 @@
     glthread = conv->threads;
     for (glpage=conv->pages; glpage; glpage=glpage->next)
     {
+       GtkNotebook *notebook = GTK_NOTEBOOK (conv->notebook);
        GtkWidget *child = glpage->data;
+       const gchar *current_label;
        g_return_if_fail (child);
 
+       current_label = gtk_notebook_get_tab_label_text (notebook, child);
+
        /* in the beginning we may have more pages than thread entries */
        if (glthread && glthread->data)
        {
-           gtk_notebook_set_tab_label_text (GTK_NOTEBOOK (conv->notebook),
-                                            child, _("active"));
+           if (!current_label || strcmp (current_label, _("active")) != 0)
+           {   /* only change the label if it has changed --
+                  otherwise our tooltips will be switched off */
+               gtk_notebook_set_tab_label_text (notebook, child, _("active"));
+           }
        }
        else
        {
-           gtk_notebook_set_tab_label_text (GTK_NOTEBOOK (conv->notebook),
-                                            child, _("inactive"));
+           if (!current_label || strcmp (current_label, _("inactive")) != 0)
+           {
+               gtk_notebook_set_tab_label_text (notebook, child, 
_("inactive"));
+           }
        }
 
        if (glthread)


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
gtkpod-cvs2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtkpod-cvs2

Reply via email to