Oops, review of HARMONY-1823 should be: The fix is to clean an interrupt flag. Patches are good.
With best regards, Alexei Fedotov, Intel Middleware Products Division >-----Original Message----- >From: Fedotov, Alexei A >Sent: Friday, October 13, 2006 6:12 PM >To: [EMAIL PROTECTED] >Cc: harmony-dev@incubator.apache.org >Subject: RE: [drlvm][unit tests] the goal is to achieve 100% pass rate > >Geir, >I reviewed the patches for HARMONY-1816 (non-daemon thread counting is done >more accurately) and for HARMONY-1823 - the fix is to clean patches are >good. > >I believe the patches worth to be committed: I've tried the patches for >running tests from luni module 162 times and get the following results: > >$ grep FAILED luni.log | sort | uniq -c > 63 [junit] TEST >org.apache.harmony.tests.internal.net.www.protocol.http >.HttpURLConnectionTest FAILED > 162 [junit] TEST tests.api.java.lang.reflect.FieldTest FAILED > 6 [junit] TEST tests.api.java.net.InetAddressTest FAILED > >The following tests were excluded: >Index: modules/luni/build.xml >=================================================================== >--- modules/luni/build.xml (revision 463342) >+++ modules/luni/build.xml (working copy) >@@ -325,6 +325,14 @@ > <exclude >name="tests/api/java/net/URLConnectionTest.jav >a" /> > <exclude name="tests/api/java/net/URLTest.java" /> > <exclude >name="tests/api/java/net/SocketPermissionTest. >java" /> >+ >+<exclude name="org/apache/harmony/luni/tests/java/lang/ThreadTest.java" /> >+<exclude name="org/apache/harmony/luni/tests/java/lang/ThreadTest.java" /> >+<exclude >name="org/apache/harmony/luni/tests/java/lang/ThreadGroupTest.java" /> > >+<exclude >name="org/apache/harmony/luni/tests/java/lang/ThreadLocalTest.java" /> > >+<exclude name="org/apache/harmony/luni/tests/java/lang/ClassTest.java" /> >+<exclude name="tests/api/java/util/FormatterTest.java" /> >+ > </fileset> > </batchtest> > >With best regards, >Alexei Fedotov, >Intel Middleware Products Division > >>-----Original Message----- >>From: Geir Magnusson Jr. [mailto:[EMAIL PROTECTED] >>Sent: Friday, October 13, 2006 9:58 AM >>To: harmony-dev@incubator.apache.org >>Subject: Re: [drlvm][unit tests] the goal is to achieve 100% pass rate >> >>great work - we'll get those applied ASAP. >> >>Elena Semukhina wrote: >>> Yesterday I tried the following patches: >>> >>> http://issues.apache.org/jira/browse/HARMONY-1592 >>> http://issues.apache.org/jira/browse/HARMONY-1816 >>> http://issues.apache.org/jira/browse/HARMONY-1823 >>> https://issues.apache.org/jira/browse/HARMONY-1741 >>> >>> They work fine. The first three patches restore recent classlib tests >>pass >>> rate degradation. >>> >>> On 10/11/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: >>> >>>> Excellent. As appreciative as I am of J9, I can't wait to work in >>>> all-Harmony code :) >>>> >>>> geir >>>> >>>> >>>> Elena Semukhina wrote: >>>> > Hello all, >>>> > >>>> > I think that the goal of running classlib unit tests on DRLVM with >>100% >>>> > pass >>>> > rate could be worth to achieve. Actually today we have 99% (without >>>> > awt/swing) but still have about 30 failures/errors. Most of them have >>>> been >>>> > evaluated and corresponding JIRAs filed. There is a page on Harmony >>>> Wiki >>>> > which lists those JIRA issues: >>>> > >>>> > http://wiki.apache.org/harmony/Unit_Tests_Pass_on_DRLVM >>>> > >>>> > Are there any volunteers to help with DRLVM bugs fixing? >>>> > >>>> > Thanks, >>>> > Elena >>>> > >>>> >>>> --------------------------------------------------------------------- >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] >>>> For additional commands, e-mail: [EMAIL PROTECTED] >>>> >>>> >>> >>> >> >>--------------------------------------------------------------------- >>Terms of use : http://incubator.apache.org/harmony/mailing.html >>To unsubscribe, e-mail: [EMAIL PROTECTED] >>For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
