>-----Original Message----- >From: Stepan Mishura [mailto:[EMAIL PROTECTED] >Sent: Thursday, November 09, 2006 9:24 AM >To: harmony-dev@incubator.apache.org >Subject: Re: svn commit: r472115 - >/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java/ comm >on/javax/swing/text/GapContent.java > >On 11/8/06, Ivanov, Alexey A wrote: >> >> >-----Original Message----- >> >From: Oleg Khaschansky >> >Sent: Wednesday, November 08, 2006 4:20 PM >> >To: harmony-dev@incubator.apache.org >> >Subject: Re: svn commit: r472115 - >> >/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java/ >> comm >> >on/javax/swing/text/GapContent.java >> > >> >> BWT, HARMONY-1809 should be marked as "non-bug difference from RI". >> >I don't think that it's non-bug diff since it fixes an API issue. >> >> I agree. This issue fixes "bad method" from JAPItools. > > > >Then we should create another JIRA to document the difference.
Yep, I thought about it too. Regards, Alexey. > >-Stepan. > >Regards, >> Alexey. >> >> > >> >On 11/8/06, Stepan Mishura <[EMAIL PROTECTED]> wrote: >> >> On 11/8/06, Ivanov, Alexey A wrote: >> >> > >> >> > Stepan, >> >> > >> >> > I must be missing something obvious... >> >> > What kind of regression test do you expect? >> >> >> >> >> >> My logic is quite straightforward: the best way to fix a decision is >> to >> >> create a regression test. For example, if another volunteer find out >> that >> >> Harmony implementation of GapContent differ from RI's and propose a >> patch >> >to >> >> fix it will any test remind him (or committer) about the decision? >> >> >> >> In our case we decided not to follow RI and do nothing for invalid >> >> parameters. So a regression test should verify that Harmony silently >> >ignores >> >> bad parameters. >> >> >> >> BWT, HARMONY-1809 should be marked as "non-bug difference from RI". >> >> >> >> Thanks, >> >> Stepan. >> >> >> >> What was done is the signature of the GapContent.replace had been >> >> > changed so that it didn't contain 'throws BadLocationException' >> clause. >> >> > >> >> > What is a regression test to demonstrate? That BadLocationException >> is >> >> > not thrown any more? >> >> > Or do you insist on setting gapStart to -2 after call replace(-2, >> 2, >> >> > null, 0), so that any subsequent operation on GapContent generates >> >> > ArrayIndexOutOfBounds? >> >> > >> >> > Regards, >> >> > Alexey. >> >> > >> >> > >> >> > P.S. The discussion thread: >> >> > >> http://thread.gmane.org/gmane.comp.java.harmony.devel/17837/focus=17837 >> >> > The related JIRA issues: >> >> > https://issues.apache.org/jira/browse/HARMONY-1809 >> >> > https://issues.apache.org/jira/browse/HARMONY-1975 >> >> > >> >> > >> >> > -- >> >> > Alexey A. Ivanov >> >> > Intel Middleware Product Division >> >> > >> >> > >> >> > >-----Original Message----- >> >> > >From: Stepan Mishura [mailto: [EMAIL PROTECTED] ] >> >> > >Sent: Wednesday, November 08, 2006 9:12 AM >> >> > >To: harmony-dev >> >> > >Subject: Re: svn commit: r472115 - >> >> > >> >>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java >> / >> >> > comm >> >> > >on/javax/swing/text/GapContent.java >> >> > > >> >> > >Hi, >> >> > > >> >> > >Any chance to see regression test (that I asked for in >> HARMONY-1975)? >> >> > :-) >> >> > > >> >> > >Thanks, >> >> > >Stepan. >> >> > > >> >> > >>-----Original Message----- >> >> > >>From: [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] >> >> > >>Sent: Tuesday, November 07, 2006 7:50 PM >> >> > >>To: [EMAIL PROTECTED] >> >> > >>Subject: svn commit: r472115 - >> >> > >> >>>/incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/jav >> a >> >> > /com >> >> > >m >> >> > > >> >> > >>on/javax/swing/text/GapContent.java >> >> > >> >> >> > >>Author: apetrenko >> >> > >>Date: Tue Nov 7 05:50:07 2006 >> >> > >>New Revision: 472115 >> >> > >> >> >> > >>URL: http://svn.apache.org/viewvc?view=rev&rev=472115 >> >> > >>Log: >> >> > >>Patch for HARMONY-1809 >> >> > >>"[classlib][swing]javax.swing.text.GapContent.replace(int, int, >> >> > >>java.lang.Object, int) throws unspescified BadLocationException" >> >> > >> >> >> > >>Modified: >> >> > >> >> >> > >> >>>incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java >> / >> >> > comm >> >> > >o >> >> > >>n/javax/swing/text/GapContent.java >> >> > >> >> >> > ><SNIP> >> >> > >> >> > >> >> -- >> >> Stepan Mishura >> >> Intel Middleware Products Division >> >> ------------------------------------------------------ >> >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> >> For additional commands, e-mail: >> [EMAIL PROTECTED] >> >> >> >> >> >> -- >> Alexey A. Ivanov >> Intel Middleware Product Division >> > > > >-- >Stepan Mishura >Intel Middleware Products Division >------------------------------------------------------ >Terms of use : http://incubator.apache.org/harmony/mailing.html >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] -- Alexey A. Ivanov Intel Enterprise Solutions Software Division
