On Sat, Sep 28, 2013 at 3:44 PM, Lior Kaplan <lio...@zend.com> wrote:
> On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans <der...@php.net> wrote: > >> And bug 31347 is that was a fix for a specific issue on Windows: >> https://bugs.php.net/bug.php?id=31347 >> > > The patch originates in Debian, and I can assure you that they don't build > for Windows (: > So that's a good point, thanks. > > We could probably test for ZEND_WIN32, or at least that's what I see at > ext/opcache/ZendAccelerator.h which just got a similar patch for GNU/Hurd > support (commit f90483001236c863abe1070d05ee2214db5a0a97). > > If that sounds OK, I'll try to do the change (although I'm not a > developer). > Ping ? I need this feedback to try and suggest a fixed patch. (sorry, not a developer, just practicing general knowledge and what I see in other commits). Kaplan
