On 2 October 2013 11:39, Lior Kaplan <lio...@zend.com> wrote:
> On Sat, Sep 28, 2013 at 3:44 PM, Lior Kaplan <lio...@zend.com> wrote:
>
>> On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans <der...@php.net> wrote:
>>
>>> And bug 31347 is that was a fix for a specific issue on Windows:
>>> https://bugs.php.net/bug.php?id=31347
>>>
>>
>> The patch originates in Debian, and I can assure you that they don't build
>> for Windows (:
>> So that's a good point, thanks.
>>
>> We could probably test for ZEND_WIN32, or at least that's what I see at
>> ext/opcache/ZendAccelerator.h which just got a similar patch for GNU/Hurd
>> support (commit f90483001236c863abe1070d05ee2214db5a0a97).
>>
>> If that sounds OK, I'll try to do the change (although I'm not a
>> developer).
>>
>
> Ping ?
>
> I need this feedback to try and suggest a fixed patch.
>
> (sorry, not a developer, just practicing general knowledge and what I see
> in other commits).
Turn it around to something like:
$ git diff
diff --git a/main/php.h b/main/php.h
index 7c1f8fd..951a4d9 100644
--- a/main/php.h
+++ b/main/php.h
@@ -254,6 +254,10 @@ END_EXTERN_C()
# endif
#endif
+#ifndef PATH_MAX
+# define PATH_MAX MAXPATHLEN
+#endif
+
#if defined(__GNUC__) && __GNUC__ >= 4
# define php_ignore_value(x) (({ __typeof__ (x) __x = (x); (void) __x; }))
#else
--
Regards,
Mike
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
