On Thu, Oct 30, 2014 at 1:21 PM, Bob Weinand <bobw...@hotmail.com> wrote:
> > Am 30.10.2014 um 13:06 schrieb Ferenc Kovacs <tyr...@gmail.com>: > On Thu, Oct 30, 2014 at 11:59 AM, Bob Weinand <bobw...@hotmail.com> wrote: > >> Hey, I can accept that. >> >> But it’d be great if you could only revert now in the 5.6.3 release >> branch, not in the 5.6 development branch, so that this gives us now still >> some time to see what exactly we want to revert or not and for some >> eventual RFC? >> > > we could do that, but that will make the RMs job much harder, because that > means that any upcoming 5.6 rc/stable release has to be always cherry > picking everything but the phpng stuff. > I think having it in the krakjoe/phpdbg repo, or in php-src but under a > feature branch would be better. > > > Actually, I just proposed as a temporary solution (which definitely should > be resolved before 5.6.4 rc1). > > An alternative would be just putting a few #if 0 in code (phpdbg_out.c > where the outputting of anything is centralized) to make XML stuff not > usable. Maybe that one is the cleanest and least invasive with still > allowing us to change the whole XML stuff. > And at the same time the normal improvements would still go into 5.6.3? > > >> To add for 3.: Issues where with what I really couldn’t think of >> (separate build dir on Linux…) or the issues with a JSON dep or Windows >> which I couldn’t test. >> > > yeah, sorry if it sounded as I'm blaming you guys, I was trying to make a > point about that big changes like that need some time to stabilize and I > also think that some of the issues would have been pointed out if there > would be some discussion prior merging a bunch of changes to php-src. > > > Well, for some part I’m to blame too as I merged a bit quickly just before > the rc… > > Also, just to point it out: Windows allows extensions to be in a random >> directory, *nix does not. I’d rather change the /acinclude.m4 to not be >> bound to the /ext directory, so that it just works like on Windows. >> (That ugly hack really annoys me too…) >> > > I could live with that, but we have to be careful when changing the build > infrastructure, because people build php on more platform than we test on. > > > I’ll be careful and test a separate build dir too first, promised. > > It wasn’t also a single feature, but more features (though XML protocol >> could be well be the cause of 1/3 of the lines changed in phpdbg)... >> > > fair enough. > is there any change which is not related to the remote debugging/new xml > protocol and you would want to have it in 5.6.3? > We are getting late with the tag, so my quick solution would be reverting > everything phpdbg related from PHP-5.6 in the last 5 days or so. > > > Well, I’d like to include as much as possible… see above. > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu > > > Bob Weinand > We discussed this with Bob on irc, and he promised that he will remove the controversial commits (the remote debugging stuff) from PHP-5.6 later today. php-5.6.3RC1 will only contain the two phpdbg commits which Joe mentioned. -- Ferenc Kovács @Tyr43l - http://tyrael.hu
