Ruby and IronRails changes are good.
The call to Handler.HandleFile could go outside of the Rails lock as there's no 
Ruby code invoked.

-----Original Message-----
From: Tomas Matousek
Sent: Friday, October 17, 2008 10:46 AM
To: IronRuby External Code Reviewers; DLR Code Reviews
Cc: [email protected]
Subject: Code Review: IronRails2

tfpt review "/shelveset:IronRails2;REDMOND\tomat"

Contains a simple change in DLR.

Ruby changes:
  Improves IronRails - switches to IIS7 integrated mode, adds a log, implements 
static file handling.
  Updates Ruby HAPI.
  Fixes writing to text streams (\n should be replaced by \r\n).
  Ruby console host exposes the current Ruby engine via "iron_ruby" variable 
int the console scope.

Tomas


_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to