I meant Ruby mspec tests located in Languages\Ruby\Tests\mspec\rubyspec\core\string (for strings). You might find they are already written but disabled. In that case remove the corresponding entries from tags: Languages\Ruby\Tests\mspec\ironruby-tags-19\core\string
You can find more on mspec here: https://github.com/rubyspec/mspec Tomas From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Roberto Perez Sent: Wednesday, May 11, 2011 3:27 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Commit to solve bug: String.delete gives a wrong result (http://ironruby.codeplex.com/workitem/5426) Ok I'll add some tests to check the functionality of this commit. I was trying to add one, but i'm having some problems passing the same "pattern string" due to the difference between ruby syntax and c# one. (As the tests are written in c#) I'll tell you as soon as I have the test done. Cheers On Wed, May 11, 2011 at 6:23 PM, Tomas Matousek <tomas.matou...@microsoft.com<mailto:tomas.matou...@microsoft.com>> wrote: I'll take a look. Could you add some tests to the specs, unless there already are some? Let me know if you have any questions. Thanks, Tomas From: ironruby-core-boun...@rubyforge.org<mailto:ironruby-core-boun...@rubyforge.org> [mailto:ironruby-core-boun...@rubyforge.org<mailto:ironruby-core-boun...@rubyforge.org>] On Behalf Of Roberto Perez Sent: Wednesday, May 11, 2011 3:56 AM To: ironruby-core@rubyforge.org<mailto:ironruby-core@rubyforge.org> Subject: [Ironruby-core] Commit to solve bug: String.delete gives a wrong result (http://ironruby.codeplex.com/workitem/5426) Hi, I committed in my fork a very small change to solve the bug which is in http://ironruby.codeplex.com/workitem/5426 The commit is in: https://github.com/robjperez/main/commit/7d94882990bc80504a78c7ed9ea989e31b8e19ed The problem was inside the range detector in the delete method. When it finds a '-' character, it assumes that the string is a range, but when you use the \ before the '-' you are telling that the '-' char is a literal. The change was in the File MutableStringOps.cs in the Delete Method. This is my first contribution to IronRuby, so I don't know if i'm following all the steps in the right order :), so, forgive me if i'm doing wrong but I followed the guides written in github wiki. Shall I proceed with the pull request to main repository, or are you going to review the commit before? Regards. Roberto -- http://zbutton.wordpress.com/ blog sobre programación y tecnología _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org<mailto:Ironruby-core@rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core -- http://zbutton.wordpress.com/ blog sobre programación y tecnología
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
