[
https://issues.apache.org/jira/browse/DBCP-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801492#action_12801492
]
Phil Steitz commented on DBCP-320:
----------------------------------
I agree - looks to me as though poolKeys can safely be eliminated. It appears
to be a global cache for UserKey objects, reused across PerUserPoolDataSource
instances and to have no purpose other than caching the UserKeys. It is
private and used only in getPoolKey.
> .PerUserPoolDataSource.poolKeys can grow without limit
> ------------------------------------------------------
>
> Key: DBCP-320
> URL: https://issues.apache.org/jira/browse/DBCP-320
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.2.2
> Reporter: Sebb
>
> The private static variable .PerUserPoolDataSource.poolKeys (a HashMap) only
> ever has items added to it; the contents are never cleared.
> Every different datasource generates a new HashMap entry; every
> username+password generates a new entry in that map.
> This might perhaps become a problem for long-running applications with lots
> of different users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
