kinow commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027097242

   - Replaced test code from `TiffOutputField` by a public getter/setter for 
the bytes data (the getter is a copy, like in other formats)
   - Updated tests to use `assertArrayEquals` from JUnit instead of custom test 
code
   - Updated a few lines to match the formatting of other classes
   - Added link to the issue/PR where the test was added (for traceability)
   - Added Javadocs to public methods changed
   
   I added a second commit so we can still revert/remove things if needed, but 
if there are no objections I think this should be ready to be merged as soon as 
CI is happy (will take a look later, gotta go :wave: :runner: )
   
   p.s. will hold merging this until the current ongoing release is out, I 
think, to avoid causing any issues with the release progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to