kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027349014
Build errors are on macos (works on macos + java 8, fails for java 11). >Error: Java heap space I will spend some minutes checking if there's any Maven setting that we can use to fix the build, but I think that shouldn't be a blocker. I still want to test this part from @StefanOltmann 's comment before merging >Drop this [testfile.jpg](https://github.com/apache/commons-imaging/assets/9299303/2826b4ee-473a-45fb-b9fc-2168b9ae3fca) into src/test/resources/data/images/jpg to make the test fail. Then I believe a good course of action here would be to merge this to get the test passing (thanks Stefan!), and continue working on #359. If I recall correctly we may not be able to include the test file, so I will check whether I can find another one, find another way to test that, or check with legal/others other options (no need to worry about this for now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
