ppkarwasz commented on code in PR #422:
URL: 
https://github.com/apache/commons-release-plugin/pull/422#discussion_r3111110788


##########
src/site/markdown/slsa/v0.1.0.md:
##########
@@ -0,0 +1,131 @@
+<!-- SPDX-License-Identifier: Apache-2.0 -->
+
+# Build Type: Apache Commons Maven Release
+
+```jsonc
+"buildType": 
"https://commons.apache.org/proper/commons-release-plugin/slsa/v0.1.0";
+```
+
+This is a [SLSA Build Provenance](https://slsa.dev/spec/v1.2/build-provenance) 
build type
+that describes releases produced by Apache Commons PMC release managers 
running Maven on their own equipment.
+
+## Build definition
+
+Artifacts are generated by a single Maven execution, typically of the form:
+
+```shell
+mvn -Prelease deploy
+```
+
+The provenance is recorded by the `build-attestation` goal of the
+`commons-release-plugin`, which runs in the `verify` phase.
+
+### External parameters
+
+External parameters capture everything supplied by the release manager at 
invocation time.
+All parameters are captured from the running Maven session.
+
+| Parameter               | Type     | Description                             
                                |
+|-------------------------|----------|-------------------------------------------------------------------------|
+| `maven.goals`           | string[] | The list of Maven goals passed on the 
command line (e.g. `["deploy"]`). |
+| `maven.profiles`        | string[] | The list of active profiles passed via 
`-P` (e.g. `["release"]`).       |
+| `maven.user.properties` | object   | User-defined properties passed via `-D` 
flags.                          |
+| `maven.cmdline`         | string   | The reconstructed Maven command line.   
                                |
+| `jvm.args`              | string[] | JVM input arguments.                    
                                |
+| `env`                   | object   | A filtered subset of environment 
variables: `TZ` and locale variables.  |
+
+### Internal parameters
+
+No internal parameters are recorded for this build type.

Review Comment:
   This purpose is to describe the contents of all user-defined element of a 
SLSA attestation. Therefore we should document the fact that 
`internalParameters` will always be empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to