[ 
https://issues.apache.org/jira/browse/CODEC-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Neidhart updated CODEC-121:
----------------------------------

    Attachment: CODEC-121_v2.patch

Hi Gary,

I have updated the patch, it now gets 100% test coverage.

Additionally, I have added a missing case of not encoded whitespace before a 
soft break and moved some repeated code into dedicated private methods to make 
the code more readable.
                
> QuotedPrintableCodec does not support soft line break per the 
> 'quoted-printable' example on Wikipedia
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CODEC-121
>                 URL: https://issues.apache.org/jira/browse/CODEC-121
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.5
>         Environment: I tested on Windows 7.
>            Reporter: Java John
>              Labels: codec, decode, quoted-printable
>             Fix For: 1.x
>
>         Attachments: CODEC-121.patch, CODEC-121_v2.patch
>
>
> Writing a unit test I discovered that the example Wikipedia uses for 
> quoted-printable data does not decode but instead throws an exception.  
> Their example is here:  http://en.wikipedia.org/wiki/Quoted-printable#Example
> test:
>   String qpdata   = "If you believe that truth=3Dbeauty, then surely=20=\r\n" 
> +
>                   "mathematics is the most beautiful branch of philosophy.";
>   String expected = "If you believe that truth=beauty, then surely " +
>                   "mathematics is the most beautiful branch of philosophy.";
>   assertEquals( expected,  new QuotedPrintableCodec().decode(qpdata) );
> I suppose I could fix if you like but currently I'm not a registered 
> developer.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to