[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807061#comment-17807061 ]
ASF GitHub Bot commented on MARCHETYPES-82: ------------------------------------------- hboutemy commented on code in PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1452971420 ########## maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml: ########## @@ -6,6 +6,7 @@ #else <maven.compiler.source>${javaCompilerVersionLocal}</maven.compiler.source> <maven.compiler.target>${javaCompilerVersionLocal}</maven.compiler.target> + <!--maven.compiler.target>11</maven.compiler.target--> Review Comment: this comment is best placed here because it is activated only when javaCompilerVersionLocal <= 8, based on effective value at runtime > generate maven.compiler.release property as comment > --------------------------------------------------- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement > Affects Versions: 1.4 > Reporter: Herve Boutemy > Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)