[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807064#comment-17807064 ]
ASF GitHub Bot commented on MARCHETYPES-82: ------------------------------------------- hboutemy commented on PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-1893138996 Many people seem not to know about ` <maven.compiler.target>11</maven.compiler.target>` adding a comment is just an idea to spread the knowledge you're right that if people grep, they'll need to take care about the comment eager to see feedback from others: is such a comment a benefit or more a problem? > generate maven.compiler.release property as comment > --------------------------------------------------- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement > Affects Versions: 1.4 > Reporter: Herve Boutemy > Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)