[
https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840059#comment-17840059
]
ASF GitHub Bot commented on MCOMPILER-515:
------------------------------------------
gnodet commented on PR #160:
URL:
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-2071969652
> > remove plexus-compiler layer but what about other compilers?
>
> `javax.tools.JavaCompiler` is an interface. From a quick search on
internet, I think (but did not verified closely) that the Eclipse compiler
implements this interface. If there is still a need for the Plexus compiler, we
can write a wrapper. The `javax.tools` API is preferred to the Plexus API
because it has some JPMS specific methods that I didn't saw in Plexus API. It
also has a method telling us whether an option is valid, and a caching
mechanism.
>
> For languages other than Java, we would need a separated plugin. With JPMS
support, multi-releases support, incremental build (even incomplete), etc.,
this plugin is very Java-specific.
The point is that this interface may not be sufficient. Ideally, we'd have
a list of output files, that would help with the heuristic.
I'm not sure the eclipse compiler is required for full incremental build, I
think the requirement for the eclipse compiler is when only exposing direct
dependencies for compiled classes (i.e. hide transitive dependencies so that
the user is forced to declare those when the code is actually using them)
> Plugin is NOT incremental, so let it go
> ---------------------------------------
>
> Key: MCOMPILER-515
> URL: https://issues.apache.org/jira/browse/MCOMPILER-515
> Project: Maven Compiler Plugin
> Issue Type: Bug
> Reporter: Tamas Cservenak
> Priority: Major
>
> The maven-compiler-plugin is NOT incremental, so we should just let it go.
> The shared incremental stuff is broken since it's last factual code change
> (2012!).
> Moreover, the broken incremental stuff just makes us look bad, see the "mvn
> clean install" vs "mvn verify" issue:
> [https://www.youtube.com/watch?v=XeQj-IbSxJI]
> Accept it, that this plugins is not incremental, so it should not make users
> believe it is. Moreover, the bugs in this feature exist for too long, that
> just cause harm to users and to project as whole.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
