JingsongLi commented on code in PR #1649:
URL: https://github.com/apache/incubator-paimon/pull/1649#discussion_r1273486105
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/TableWriteOperator.java:
##########
@@ -91,7 +93,18 @@ void initStateAndWriter(
// runtime context, we can test to construct a writer here
state = new StoreSinkWriteState(context, stateFilter);
- write = storeSinkWriteProvider.provide(table, commitUser, state,
ioManager, memoryPool);
+ write =
+ storeSinkWriteProvider.provide(
+ table,
+ commitUser,
+ state,
+ ioManager,
+ new MemoryPoolFactory(
+ memoryPool != null
+ ? memoryPool
+ : new HeapMemorySegmentPool(
Review Comment:
default null？
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/TableWriteOperator.java:
##########
@@ -91,7 +93,18 @@ void initStateAndWriter(
// runtime context, we can test to construct a writer here
state = new StoreSinkWriteState(context, stateFilter);
- write = storeSinkWriteProvider.provide(table, commitUser, state,
ioManager, memoryPool);
+ write =
+ storeSinkWriteProvider.provide(
+ table,
+ commitUser,
+ state,
+ ioManager,
+ new MemoryPoolFactory(
+ memoryPool != null
+ ? memoryPool
+ : new HeapMemorySegmentPool(
Review Comment:
default null？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
