JingsongLi commented on code in PR #1649:
URL: https://github.com/apache/incubator-paimon/pull/1649#discussion_r1273486738
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/StoreSinkWriteImpl.java:
##########
@@ -80,12 +80,13 @@ private TableWriteImpl<?> newTableWrite(FileStoreTable
table) {
(part, bucket) ->
state.stateValueFilter().filter(table.name(),
part, bucket))
.withIOManager(new
IOManagerImpl(ioManager.getSpillingDirectoriesPaths()))
- .withMemoryPool(
- memoryPool != null
- ? memoryPool
- : new HeapMemorySegmentPool(
- table.coreOptions().writeBufferSize(),
- table.coreOptions().pageSize()))
+ .withMemoryPoolFactory(
+ memoryPoolFactory != null
+ ? memoryPoolFactory
+ : new MemoryPoolFactory(
Review Comment:
maybe here default null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
