| From: Brian Jackson <[EMAIL PROTECTED]>
| D. Hugh Redelmeier wrote:
| > It is great that driver/Makefile2.6's install target checks for
| > pre-existing modules that might conflict with ivtv's. In this patch,
| > I improve on this check:
| <snip>
| > + @ for m in ` find /lib/modules/$(KVER)/kernel -name msp3400.ko -o
| > -name tuner.ko -o -name tda9887.ko -o -name tveeprom.ko ` ; \
|
| Should probably just be /lib/modules/$(KVER) certain packages put modules at
| the same level as kernel.
It appears that you are quite right. I just naively generalized the
existing code. On my Fedora Core 3 (the system at hand, not the one
with ivtv), there is no kernel subdirectory.
I vaguely remember that some version/mutation of IVTV used module
names with -ivtv added. Should those names be checked for? Are there
other variants?
The code I wrote is a bit brittle. If new modules are added or
modules are removed, the find command's expression must be modified by
hand. At the cost of some efficiency, it could be made
self-adjusting:
for n in *.ko
for m in ` find /lib/modules/$(KVER)/kernel -name $n `
I think that this is worth the extra time.
Opinions?
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel
