On Sun, 22 Jan 2006, Charles O Nutter defenestrated me:

> I hate when I do that. Patch attached.
> 
> On 1/22/06, Charles O Nutter <[EMAIL PROTECTED]> wrote:
> > This fix allows the module/class comparison operators to work like
> > they're supposed to: returning nil when two compared classes are on
> > different branches of the hierarchy. I found this issue running C
> > ruby's test_const. It runs 100% now.
> >
> > I'm still not happy with the way it's doing the comparison (checking
> > for == in the method lists has always been and still is an UGLY hack)
> > but I didn't address that in this patch.
> >
> > Patch was made against cnutter_work1, but should apply fine to HEAD.
> > Please confirm.
> >
> > - Charlie
> >

nit:

if (a)
  return
else if (b)
  return
else
  return

Should lop off the else:

if (a)
  return
else if (b)
  return

return

Other than that it looks good...

-Tom

-- 
+ http://www.tc.umn.edu/~enebo +---- mailto:[EMAIL PROTECTED] ----+
| Thomas E Enebo, Protagonist  | "Luck favors the prepared    |
|                              |  mind." -Louis Pasteur       |


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Jruby-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jruby-devel

Reply via email to