> nit:
>
> if (a)
> return
> else if (b)
> return
> else
> return
>
> Should lop off the else:
>
> if (a)
> return
> else if (b)
> return
>
> return
Should lop off ALL the elses.
if (a)
return
if (b)
return
return
>
> Other than that it looks good...
>
> -Tom
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Jruby-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jruby-devel