On Tue, 21 Mar 2006, Charles O Nutter defenestrated me:
> 
>    Two fixes so far:
>    1. Added CRC32Ext based on Adler32Ext - seemed to be missing when I
>    updated my branch from HEAD, perhaps it was not in the original patch,
>    or got missed.
>    2. Added defaults to GZipWriter#initialize to match open and
>    Deflate#new:
>        def initialize(io, level=nil, strategy=nil)
>          @io = GZIPOutputStream.new(IOConverter.new(io).asOutputStream)
>        end
>    Odd that this doesn't show up in any documentation.

  I added a few fixes of my own:
1. GZipWriter.open to allow case where no block is present
2. GZipReader.open to allow case where no block is present
3. GZipWriter.puts was not passing opts properly (opts versus *opts).

  Plus:
1. print, puts, printf were all broken in stringio.rb

I created a new unit test file 'test/testZlib.rb'

>    Current issue is that in the above initialize method, the
>    GZIPOutputStream.new is being passed a RubyObject, not an
>    OutputStream. Looks like a JRuby issue.

Works for me...but stringio had bad puts/print/printf impls.  Could it have 
been that?

-Tom

-- 
+ http://www.tc.umn.edu/~enebo +---- mailto:[EMAIL PROTECTED] ----+
| Thomas E Enebo, Protagonist  | "Luck favors the prepared    |
|                              |  mind." -Louis Pasteur       |


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Jruby-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jruby-devel

Reply via email to