https://bugs.kde.org/show_bug.cgi?id=338742
Albert Astals Cid <aa...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/oku | |lar/ad1160be1b370ca512a741c | |1a12f9eff0ca5848c --- Comment #6 from Albert Astals Cid <aa...@kde.org> --- Git commit ad1160be1b370ca512a741c1a12f9eff0ca5848c by Albert Astals Cid, on behalf of Henrik Fehlauer. Committed on 05/02/2018 at 23:31. Pushed by aacid into branch 'Applications/17.12'. Fix saving annotations to gzipped files Okular supports opening zipped files like document.pdf.gz by transparently extracting them. However, since 559836c39270 saving annotations back was broken. This is because this commit tries to prevent saving back changes to externally modified files to prevent data loss. The way this is checked by comparing timestamps mistakenly triggered for unchanged zipped files, too. This can be solved by always comparing the before/after timestamps of the actual file, instead of the timestamp of the temporary copy of the extracted file. The change has to be done in two places so saving repeatedly works too. Test plan gzip autotests/data/file1.pdf && okular file1.pdf.gz Add annotation, saving works now instead of showing an error. touch normal.pdf still triggers modification warning. Differential Revision: https://phabricator.kde.org/D9580 M +2 -2 part.cpp https://commits.kde.org/okular/ad1160be1b370ca512a741c1a12f9eff0ca5848c -- You are receiving this mail because: You are watching all bug changes.