https://bugs.kde.org/show_bug.cgi?id=386163

--- Comment #4 from Nate Graham <pointedst...@zoho.com> ---
Git commit 2c31ae4acba9bce24953c0f2584cd15589c4bb71 by Nathaniel Graham.
Committed on 05/02/2018 at 23:31.
Pushed by ngraham into branch 'master'.

(1/3) Remove unnecessary Discard/Quit button

Summary:
Part 1 of 3 for {T7841}
FIXED-IN: 18.04

Spectacle's main window doesn't need a discard/quit button, because there's
already a user-visible way of closing the window: the titlebar's close button.
The escape key does it, too. This button duplicates existing functionality and
takes up room that could be used for a "Configure..." button, and has led to
user confusion in the past as well (see
https://bugs.kde.org/show_bug.cgi?id=386163)

Test Plan:
Tested in KDE Neon:
- Can still quit with the Escape key
- Quitting automatically discards the current screenshot if it has not been
saved yet
- There's now more room in the button bar so we can add a visible
"Configure..." button

{F5690995}

Reviewers: #spectacle, alexeymin

Reviewed By: #spectacle, alexeymin

Subscribers: alexeymin

Differential Revision: https://phabricator.kde.org/D10283

M  +0    -6    doc/index.docbook
M  +1    -7    src/Gui/KSMainWindow.cpp

https://commits.kde.org/spectacle/2c31ae4acba9bce24953c0f2584cd15589c4bb71

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to