https://bugs.kde.org/show_bug.cgi?id=414268

--- Comment #7 from Peter Maydell <peter.mayd...@linaro.org> ---
Your logic attempting to identify v8.1, v8.2, etc isn't right. For instance:

+     /* Must be at least v8.2 if DC CVAP instruction available. */
+     if (have_dpbcvap)
+        SET_VEX_ARM64_ARCHLEVEL(vai.hwcaps, VEX_HWCAPS_ARM64_V82);

It's true that if you are v8.2 or better then DC CVAP is present, but this does
not mean the converse (that if DC CVAP is present then you are v8.2). It is
valid for a v8.1 implementation to provide this feature.

I still think it would be better not to try to identify and base anything on
v8.1 vs v8.2 vs v8.3...chances are really high that if some code is using "is
this v8.1 ?" as a condition on something then that code is wrong, because it
should be checking for a more specific feature field (or it will behave
incorrectly on hardware which provides that feature without necessarily being
the v8.x version where that feature became mandatory, or whatever).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to