Hello there,

I just ran the static analyser "cppcheck" over the source code of lftp-4.4.9

It said

[Fish.h:92]: (warning) Ineffective call of function 'empty()'. Did you intend 
to call 'clear()' instead?
[Fish.h:92]: (warning) Ineffective call of function 'empty()'. Did you intend 
to call 'clear()' instead?
[Torrent.cc:1656]: (warning) Ineffective call of function 'empty()'. Did you 
intend to call 'clear()' instead?
[Torrent.cc:1664]: (warning) Ineffective call of function 'empty()'. Did you 
intend to call 'clear()' instead?
[Torrent.cc:1665]: (warning) Ineffective call of function 'empty()'. Did you 
intend to call 'clear()' instead?
[Torrent.cc:2095]: (warning) Ineffective call of function 'empty()'. Did you 
intend to call 'clear()' instead?
[Torrent.cc:2154]: (warning) Ineffective call of function 'empty()'. Did you 
intend to call 'clear()' instead?
[DHT.cc:1009]: (warning) Ineffective call of function 'empty()'. Did you intend 
to call 'clear()' instead?
[DHT.cc:1010]: (warning) Ineffective call of function 'empty()'. Did you intend 
to call 'clear()' instead?

I checked the first two and they looked like real problems to me.
Suggest code rework.

Regards

David Binderman                                           
_______________________________________________
lftp-devel mailing list
lftp-devel@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp-devel

Reply via email to