On Mon, Jun 01, 2009 at 05:47:42PM +0100, James Mansion wrote: [...] > Actually nonpersist_readd fails sometimes too - it hits one of the > exit(1)s. Shouldn't > the test just fail?
Well, it should _pass_, actually. ;) But yeah, in the new "tinytest" system, a test should call tt_fail() rather than exit(). The nonpersist_readd() test calls exit() because it's a legacy test: it was written before we switched from the ad-hoc unit test system to the current test system. If somebody wants to convert all the old legacy tests to use the tt_* macros, that would be a fine thing. (One of the reasons that tinytest runs each test case in a subprocess is so that old tests can fail by calling exit() or assert() without bringing the entire testing process to a halt.) -- Nick Mathewson _______________________________________________ Libevent-users mailing list Libevent-users@monkey.org http://monkeymail.org/mailman/listinfo/libevent-users
