core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/stringconstant.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f1697d2b1e6b3ac63946070cc720234dc68efbe9
Author:     Stephan Bergmann <stephan.bergm...@allotropia.de>
AuthorDate: Mon Apr 8 08:05:17 2024 +0200
Commit:     Stephan Bergmann <stephan.bergm...@allotropia.de>
CommitDate: Mon Apr 8 09:50:46 2024 +0200

    -Werror,-Wunused-but-set-variable
    
    ...ever since the code got introduced in
    4f5b3e4bd53d6d61df1f65f496f7bc8dc525c8a1 "In O[U]StringBuffer, make 
string_view
    params replacements for OUString ones"
    
    Change-Id: If2032db027f45c60f7c92b796a0a10d23f26b6e4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165881
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>

diff --git a/compilerplugins/clang/stringconstant.cxx 
b/compilerplugins/clang/stringconstant.cxx
index 134be1940b82..344125dd4df0 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -96,7 +96,7 @@ CXXConstructExpr const * lookForCXXConstructExpr(Expr const * 
expr) {
     }
     if (auto const e = dyn_cast<CXXMemberCallExpr>(expr)) {
         // Look through OString::operator std::string_view:
-        if (auto const d = 
dyn_cast_or_null<CXXConversionDecl>(e->getCalleeDecl())) {
+        if (isa_and_nonnull<CXXConversionDecl>(e->getCalleeDecl())) {
             return 
lookForCXXConstructExpr(e->getImplicitObjectArgument()->IgnoreParenImpCasts());
         }
     }