On Sat, 2017-07-08 at 16:58 +0200, Simon Albrecht wrote:
> On 08.07.2017 15:49, Richard Shann wrote:
> > I was intrigued by this, as I have a patch to the figured bass formatter
> > that has been hanging around because the route to making contributions
> > that I knew about involved a virtual machine which I can't get working
> > on my current system.
> 
> The method Urs named is possible with openLilyLib, but not with the 
> LilyPond source.  That
> means you would have to get a VM to work, or install a Unix system in 
> parallel – both a lot of
> effort for one small patch obviously.  Or you just e-mail your patch to 
> the devel list and ask for
> someone to shepherd it through the review process and into the code base 
> for you, which is done
> from time to time.
Thanks - here is such a small patch then. It fixes the centering of
isolated accidentals and digits on whole notes which is currently too
far to the left.
Here is a snippet that illustrates the problem.
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<
   {
    c''1 c'' c'' c''
    c''4 c'' c'' c''

  }
  \new FiguredBass {
    \figuremode {
      <_+>1 <_-> <3> <3+>
      <_+>4 <_-> <3> <3+>
    }
  }
>>
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

Richard

--- ORIG_translation-functions.scm	2017-07-08 12:36:17.716097042 +0100
+++ translation-functions.scm	2017-07-09 11:34:13.248080809 +0100
@@ -184,13 +184,10 @@ way the transposition number is displaye
           (set! alt-markup #f)))
 
 
-    ;; hmm, how to get figures centered between note, and
-    ;; lone accidentals too?
-
-    ;;    (if (markup? fig-markup)
-    ;;  (set!
-    ;;   fig-markup (markup #:translate (cons 1.0 0)
-    ;;                      #:center-align fig-markup)))
+    (if (and (eqv? 0 (ly:duration-log  (ly:event-property event 'duration))) (markup? fig-markup))
+        (set!
+        fig-markup (markup #:translate (cons 1.0 0)
+                        #:center-align fig-markup)))
 
     (if alt-markup
         (set! fig-markup
_______________________________________________
lilypond-user mailing list
lilypond-user@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-user

Reply via email to