> > > This patch makes ->ru_maxrss value in struct rusage filled accordingly to > > > rss hiwater mark. This struct is filled as a parameter to > > > getrusage syscall. ->ru_maxrss value is set to pages which might be > > > correct > > > as "time" application converts it to KBs. > > > > Why? > > if kernel convert to KB, glibc don't need any change. > Where exactly glibc is working with this as KBs? I can't find that place. > > I looked into sources of time util and maxrss is showed this way: > fprintf (fp, "%lu", ptok ((UL) resp->ru.ru_maxrss)); > ptok() actually does pages_to_KB conversion. If we convert to KB in > kernel, this code must be changed.
Ah, you talked about /usr/bin/time? sorry, I misunderstood a bit. Why time need number of pages? In general, getrusage()::ru_maxrss is bsd compatibility feature. as far as possible, the same syscall spec is better. and bsd use KB unit. if time command has reasonable reason, I can agree current design. but is there? -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
