> No, this goes beyond PPC/OF. The real issue is that it is no longer a > safe assumption that pdata will be a static data structure in platform > code. The number of possible data sources is going to get larger, not > smaller. OF is just one. UEFI is another. Translating that data > into pdata will be the problem that comes up over and over again. > However, translation code is still driver specific, so it belongs with > the driver that it translates code for. > > So, in my opinion, translation code must: > 1. be *tiny* -- should be trivial to add to a driver without impacting > common code > 2. live with the driver that it translates data for; ideally in the > same .c file for drivers that are small.
I am with Grant on these points. It is more than just PPC. > > No matter how small the OF code is, I believe we shouldn't put it > > into the generic code. Take a look at mmc_spi case again, it can be > > easily extended to any arch, because there is no arch-specific stuff, > > but a "get/put" pattern for platform data. Will check this tomorrow. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
