Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH

[Richard Cochran]

On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote:
> +/* HW TS */
> +static int cpts_extts_enable(struct cpts *cpts, u32 index, int on)
> +{
> +     unsigned long flags;
> +     u32 v;
> +
> +     if (index >= cpts->info.n_ext_ts)
> +             return -ENXIO;
> +
> +     if (((cpts->hw_ts_enable & BIT(index)) >> index) == on)
> +             return 0;
> +
> +     spin_lock_irqsave(&cpts->lock, flags);
> +
> +     v = cpts_read32(cpts, control);
> +     if (on) {
> +             v |= BIT(8 + index);
> +             cpts->hw_ts_enable |= BIT(index);
> +     } else {
> +             v &= ~BIT(8 + index);
> +             cpts->hw_ts_enable &= ~BIT(index);
> +     }
> +     cpts_write32(cpts, v, control);
> +
> +     spin_unlock_irqrestore(&cpts->lock, flags);
> +
> +     if (cpts->hw_ts_enable)
> +             /* poll for events faster - evry 200 ms */

every

> +             cpts->ov_check_period =
> +                     msecs_to_jiffies(CPTS_EVENT_HWSTAMP_TIMEOUT);

Bad indentation.  Use braces {} to contain the comment and assignment
statement.

> +     else
> +             cpts->ov_check_period = cpts->ov_check_period_slow;
> +
> +     mod_delayed_work(system_wq, &cpts->overflow_work,
> +                      cpts->ov_check_period);
> +
> +     return 0;
> +}

Thanks,
Richard