On Mon, Apr 24, 2017 at 10:06:32PM +0900, Tetsuo Handa wrote: > Stanislaw Gruszka wrote: > > On Sun, Apr 23, 2017 at 07:24:21PM +0900, Tetsuo Handa wrote: > > > On 2017/03/10 20:44, Tetsuo Handa wrote: > > > > Michal Hocko wrote: > > > >> I am definitely not against. There is no reason to rush the patch in. > > > > > > > > I don't hurry if we can check using watchdog whether this problem is > > > > occurring > > > > in the real world. I have to test corner cases because watchdog is > > > > missing. > > > > > > > Ping? > > > > > > This problem can occur even immediately after the first invocation of > > > the OOM killer. I believe this problem can occur in the real world. > > > When are we going to apply this patch or watchdog patch? > > > > > > ---------------------------------------- > > > [ 0.000000] Linux version 4.11.0-rc7-next-20170421+ (root@ccsecurity) > > > (gcc version 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC) ) #588 SMP Sun Apr > > > 23 17:38:02 JST 2017 > > > [ 0.000000] Command line: > > > BOOT_IMAGE=/boot/vmlinuz-4.11.0-rc7-next-20170421+ > > > root=UUID=17c3c28f-a70a-4666-95fa-ecf6acd901e4 ro vconsole.keymap=jp106 > > > crashkernel=256M vconsole.font=latarcyrheb-sun16 security=none > > > sysrq_always_enabled console=ttyS0,115200n8 console=tty0 LANG=en_US.UTF-8 > > > debug_guardpage_minorder=1 > > > > Are you debugging memory corruption problem? > > No. Just a random testing trying to find how we can avoid flooding of > warn_alloc_stall() warning messages while also avoiding ratelimiting.
This is not right way to stress mm subsystem, debug_guardpage_minorder= option is for _debug_ purpose. Use mem= instead if you want to limit available memory. > > FWIW, if you use debug_guardpage_minorder= you can expect any > > allocation memory problems. This option is intended to debug > > memory corruption bugs and it shrinks available memory in > > artificial way. Taking that, I don't think justifying any > > patch, by problem happened when debug_guardpage_minorder= is > > used, is reasonable. > > > > Stanislaw > > This problem occurs without debug_guardpage_minorder= parameter and So please justify your patches by that. Thanks Stanislaw
