>> +&edma1 {
>> +    status = "okay";
>> +};
>> +
>> +&dspi2 {
> 
> Please keep these labelled nodes sort alphabetically.

Ok

>> +    bus-num = <1>;
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&pinctrl_dspi2>;
>> +    status = "okay";
> 
> We usually have 'status' line at the bottom of property list.

Ok

>> +    spi-num-chipselects = <2>;
>> +
>> +    hi8435@1 {
> 
> Node name should be something generic, while label can be specific
> model name.  The following form might be better.
> 
>       hi8435: sensor@1

Ok

Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.

Anyway let's delay this a bit, up to the reset polarity description
thing in hi8435 is resolved.

Nikita

Reply via email to