On Sat, Jun 10, 2017 at 12:51:57PM +0000, Mintz, Yuval wrote:
> > This adds the support of the debugfs interface to the driver for debugging
> > purposes.
>
> > +const struct hclge_support_cmd support_cmd[] = {
> > + {"send cmd", 8, hclge_dbg_send,
> > + "opcode flag data0 data1 data2 data3 data4 data5"},
> > + {"help", 4, hclge_dbg_usage, "no option"}, };
>
> Is there an actual description of what this does? Or is it simply a huge
> backdoor?
It looks like a huge backdoor to the chip.
It is O.K. to have such a patch internally for your own development
work, but it should not be submitted for mainline.
NACK
Andrew
