On Mon, 12 Jun 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <[email protected]> > --- > drivers/usb/host/ehci-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c > index 7a603f6..26b6411 100644 > --- a/drivers/usb/host/ehci-exynos.c > +++ b/drivers/usb/host/ehci-exynos.c > @@ -279,7 +279,9 @@ static int exynos_ehci_resume(struct device *dev) > struct exynos_ehci_hcd *exynos_ehci = to_exynos_ehci(hcd); > int ret; > > - clk_prepare_enable(exynos_ehci->clk); > + ret = clk_prepare_enable(exynos_ehci->clk); > + if (ret) > + return ret; > > ret = exynos_ehci_phy_enable(dev); > if (ret) {
Acked-by: Alan Stern <[email protected]>
