On Tue, Apr 24, 2018 at 10:03 AM, Arvind Yadav <arvind.yadav...@gmail.com> wrote: > Free device resource data, if __wacom_devm_sysfs_create_group > is not successful. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> > ---
Looks good to me: Reviewed-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Cheers, Benjamin > drivers/hid/wacom_sys.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c > index b54ef1f..ee7a37e 100644 > --- a/drivers/hid/wacom_sys.c > +++ b/drivers/hid/wacom_sys.c > @@ -1213,8 +1213,10 @@ static int __wacom_devm_sysfs_create_group(struct > wacom *wacom, > devres->root = root; > > error = sysfs_create_group(devres->root, group); > - if (error) > + if (error) { > + devres_free(devres); > return error; > + } > > devres_add(&wacom->hdev->dev, devres); > > -- > 1.9.1 >