On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote: > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote: > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot <l...@intel.com> wrote: > > > > > Hi Andrey, > > > > > > I love your patch! Yet something to improve: > > > > > > [auto build test ERROR on mmotm/master] > > > [cannot apply to v4.17-rc6] > > > [if your patch is applied to the wrong git tree, please drop us a note to > > > help improve the system] > > > > > > url: https://github.com/0day-ci/linux/commits/Andrey-Ryabinin/mm-kasan- > > > do > > > nt-vfree-nonexistent-vm_area-fix/20180526-093255 > > > base: git://git.cmpxchg.org/linux-mmotm.git master > > > config: sparc-allyesconfig (attached as .config) > > > compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > > > reproduce: > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin > > > /m > > > ake.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # save the attached .config to linux build tree > > > make.cross ARCH=sparc > > > > > > All errors (new ones prefixed by >>): > > > > > > fs/autofs/inode.o: In function `autofs_new_ino': > > > inode.c:(.text+0x220): multiple definition of `autofs_new_ino' > > > fs/autofs/inode.o:inode.c:(.text+0x220): first defined here > > > fs/autofs/inode.o: In function `autofs_clean_ino': > > > inode.c:(.text+0x280): multiple definition of `autofs_clean_ino' > > > fs/autofs/inode.o:inode.c:(.text+0x280): first defined here > > > > There's bot breakage here - clearly that patch didn't cause this error. > > > > Ian, this autofs glitch may still not be fixed. > > Yes, autofs-make-autofs4-Kconfig-depend-on-AUTOFS_FS.patch should have > fixed that. > > I tied a bunch of .config combinations and I was unable to find any that > lead to both CONFIG_AUTOFS_FS and CONFIG_AUTOFS4_FS being defined.
Oh, autofs-make-autofs4-Kconfig-depend-on-AUTOFS_FS.patch was sent as a follow up patch which means it's still possible to have both CONFIG_AUTOFS_FS and CONFIG_AUTOFS4_FS set between autofs-create-autofs-Kconfig-and-Makefile.patch and the above patch. Perhaps all that's needed is to fold the follow up patch into autofs-create-autofs-Kconfig-and-Makefile.patch to close that possibility. I'll check that can be done without problem. > > I must be missing something else, I'll investigate. And I'll check if there's anything else I'm missing. Sorry for the inconvenience. > > Ian
