On 7/20/07, Neil Brown <[EMAIL PROTECTED]> wrote:
On Thursday July 19, [EMAIL PROTECTED] wrote:
> On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote:
> > On Wednesday July 18, [EMAIL PROTECTED] wrote:
> > > OK, here I'm still confused--what should we be doing instead?
> >
> > Cast the variable to a type that printf knows about.
> > seq_printf(m, ",anonuid=%d", (int)anonu);
> >
> > Or maybe cast it to (long) and use %ld, just in case...
>
> OK. In the event that uid_t some day ceases to eventually become an
> int, will the casts help, or will they just suppress useful warnings?
Probably not. Just leave it as it is.
>
> > Note the stray 's' in the current patch, after the comma!
>
> Sharp eyes, thanks! I'll make a patch. Uh, any objection if I print
> all those uid's as unsigned while I'm at it?
I wondered about that too. I think we have completely removed the
fiction that 'nobody' is '-2' rather than '65534' so it should be both
safe and sensible to make them unsigned.
Ummm ... sorry for butting in here :-) But uid_t is always unsigned, yes.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
