Fix buffer overflow observed when running perf test.

The overflow is when trying to evaluate "1ULL << (64 - 1)" which
is resulting in -9223372036854775808 which overflows the 20 character
buffer.

If is possible this bug has been reported before but I still don't
see any fix checked in:

See: https://www.spinics.net/lists/linux-perf-users/msg07714.html

Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: linux-perf-us...@vger.kernel.org
Cc: Steven Rostedt <rost...@goodmis.org>
Signed-off-by: Tony Jones <to...@suse.de>
---
 tools/lib/traceevent/event-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/event-parse.c 
b/tools/lib/traceevent/event-parse.c
index abd4fa5d3088..87494c7c619d 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2457,7 +2457,7 @@ static int arg_num_eval(struct tep_print_arg *arg, long 
long *val)
 static char *arg_eval (struct tep_print_arg *arg)
 {
        long long val;
-       static char buf[20];
+       static char buf[24];
 
        switch (arg->type) {
        case TEP_PRINT_ATOM:
-- 
2.20.1

Reply via email to