> -----Original Message----- > From: linux-edac-ow...@vger.kernel.org <linux-edac-ow...@vger.kernel.org> On > Behalf Of Luck, Tony > Sent: Monday, April 8, 2019 6:23 PM > To: Ghannam, Yazen <yazen.ghan...@amd.com> > Cc: Borislav Petkov <b...@alien8.de>; linux-e...@vger.kernel.org; > linux-kernel@vger.kernel.org; x...@kernel.org > Subject: Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu > > On Mon, Apr 08, 2019 at 10:48:34PM +0000, Ghannam, Yazen wrote: > > Okay, so drop the export and leave the injector code as-is (it's > > already doing a rdmsrl_on_cpu()). > > It's still a globally visible symbol (shared by core.c and amd.c). > So I think it needs a "mce_" prefix. > > While it doesn't collide now, there are a bunch of other > subsystems that have "banks" and a variable to count them. > > Look at output from "git grep -w num_banks". >
Okay, I'll add the prefix. And thanks for the tip. I'll try to keep this in mind. Thanks, Yazen
