On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote: > The following is the qos_param patch that implements a genralization of > latency.c. >
Just some general comments (as on irc): - use 'diffstat -p1 -w70' to summarize each patch - use checkpatch.pl to check for coding style and other buglets - has no API docs :( > +/* assumes qos_lock is held */ > +static void update_target(int i) I'd prefer a better arg name than 'i'. > +{ --- ~Randy Phaedrus says that Quality is about caring. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/