Re: [PATCH v3 02/13] ata: ahci_brcm: Fix use of BCM7216 reset controller

[Florian Fainelli]

On 6/3/2020 12:20 PM, Jim Quinlan wrote:
> From: Jim Quinlan <jquin...@broadcom.com>
> 
> A reset controller "rescal" is shared between the AHCI driver and the PCIe
> driver for the BrcmSTB 7216 chip.  The code is modified to allow this
> sharing and to deassert() properly.
> 
> Signed-off-by: Jim Quinlan <jquin...@broadcom.com>
> 
> Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting")
> Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller
> name")
> ---

[snip]

> @@ -479,10 +478,7 @@ static int brcm_ahci_probe(struct platform_device *pdev)
>               break;
>       }
>  
> -     if (priv->version == BRCM_SATA_BCM7216)
> -             ret = reset_control_reset(priv->rcdev);
> -     else
> -             ret = reset_control_deassert(priv->rcdev);
> +     ret = reset_control_deassert(priv->rcdev);
>       if (ret)
>               return ret;

Do we need a similar change for brcm_ahci_resume()?
-- 
Florian